Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade action to NodeJS v20 #58

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jozefizso
Copy link
Contributor

Fixes #57
Fixes #56

@jozefizso
Copy link
Contributor Author

Hi @orj, can you check out this PR?

@FelixLisczyk
Copy link

Are there any updates on this PR? Thank you for your work! 😊

@manuelpagliuca
Copy link

When this is going to be merged?

@grzegorzkrukowski
Copy link

grzegorzkrukowski commented Mar 7, 2024

GitHub announced that they will enforce node20 instead of a warning on 13th May

@paulmcgrathparamount
Copy link

Any updates on this PR getting merged?

@jozefizso
Copy link
Contributor Author

You can use this fork until this gets merged:

https://github.com/slidoapp/import-codesign-certs

@XaviTorello
Copy link

@orj any news about this PR?

@XaviTorello
Copy link

You can use this fork until this gets merged:

https://github.com/slidoapp/import-codesign-certs

@jozefizso's fork is working perfectly

In the meantime, it can be integrated with uses: slidoapp/import-codesign-certs@node20

Ty dude :)

@patattack69
Copy link

Just to be clear I mention that this PR has not moved in 5 months and using @XaviTorello suggestion until it does. Why is this taking so long is this project dead?

@jozefizso
Copy link
Contributor Author

Hi @orj , I hope you are doing well.

I'm checking if you could review this PR so others can enjoy the import-codesign-certs action running on latest NodeJS 20 runtime.

@ssrobins
Copy link
Contributor

Thanks for your patience here. I was added as a maintainer to help with the node 16 upgrade, but I neglected to hit 'watch' on the repo so I wasn't getting any notifications. I also wasn't using my GitHub hobby projects much so I didn't see the deprecation warning until recently.

Node is now upgraded to 20 with #64 and I added a v3 tag with those changes. I'm not closing this PR since there are some valuable upgrades here. I can try to get to this next week, perhaps. In the meantime, if you wanted to update your branch to re-run the checks, that would be helpful.

@arifali123
Copy link
Contributor

I originally checked out this pr before making #64 but decided to make mine because just changing to node20 would possibly make the review faster. These upgrades seem fine after testing it locally and inside my github action since its just upgrades of devDependencies.

@AdrianEddy
Copy link

Thanks for the update! It would be great to also update the apple-actions/download-provisioning-profiles action since you're at it

@ssrobins
Copy link
Contributor

Thanks for the update! It would be great to also update the apple-actions/download-provisioning-profiles action since you're at it

It's done, please use apple-actions/download-provisioning-profiles@v3.

@espenrl
Copy link

espenrl commented May 12, 2024

Great work @ssrobins It would be super to also update Apple-Actions/upload-testflight-build

@jozefizso
Copy link
Contributor Author

Hi @ssrobins, thanks for looking at this PR.

I have rebased it on the master and update npm package to latest version.
I did not update the eslint as the latest major release is not compatible with the @typescript-eslint/parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated